Skip to content

PERF: new_block #52326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 3, 2023
Merged

PERF: new_block #52326

merged 4 commits into from
Apr 3, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Performance Memory or execution speed performance Internals Related to non-user accessible pandas implementation labels Mar 31, 2023
@mroeschke
Copy link
Member

Any idea on the perf improvement?

@jbrockmendel
Copy link
Member Author

Any idea on the perf improvement?

In the branch in #52291 I'm seeing about 4% of the runtime in check_ndim call that this removes. #52316 will cause that number to increase.

@mroeschke mroeschke added this to the 2.1 milestone Apr 3, 2023
@mroeschke mroeschke merged commit 15fd7d7 into pandas-dev:main Apr 3, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the perf-new_block branch April 3, 2023 21:51
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 6, 2023
@jbrockmendel @topper-123
PERF: new_block (pandas-dev#52326)
879de79 
* PERF: new_block

* fix arraymanager build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Performance Memory or execution speed performance
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke